Fixed scrollbars and reduced first responder juggling #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amzd
commented
Oct 19, 2024
r10s
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
thanks a lot for taking care! ❤️ this fixes all the issues i discovered after #2315 got merged!
also the code looks excellent and understandable to me, and also makes sense to me. i suggest to merge this PR as it fixes blocking issues.
for the testing: how can i start this testing in iOS? maybe we can add some hints to the README
| @@ -2,7 +2,7 @@ import UIKit | |||
| import DcCore | |||
|
|
|||
| public class DraftArea: UIView, InputItem { | |||
| public var inputBarAccessoryView: InputBarAccessoryView? | |||
| public weak var inputBarAccessoryView: InputBarAccessoryView? | |||
That was not intended to be included in this PR, it is not fully done yet. There is some issues I still need to figure out. |
r10s
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2323